Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Update to latest golden images #64315

Merged
merged 3 commits into from May 23, 2023

Conversation

s0undt3ch
Copy link
Member

What does this PR do?

See title

@s0undt3ch s0undt3ch requested a review from a team as a code owner May 22, 2023 10:07
@s0undt3ch s0undt3ch requested review from garethgreenaway and removed request for a team May 22, 2023 10:07
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Update to latest golden images [3006.x] Update to latest golden images May 22, 2023
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 10:23 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 10:23 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 10:23 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 13:57 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 13:57 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 13:57 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 15:55 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 15:55 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 15:56 — with GitHub Actions Inactive
twangboy
twangboy previously approved these changes May 22, 2023
@dmurphy18
Copy link
Contributor

@s0undt3ch Given Fedora 36 is EOL now, any point in still having it ?

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Copy link
Member Author

@s0undt3ch Given Fedora 36 is EOL now, any point in still having it ?

Removed.

@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 18:42 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 18:44 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 18:44 — with GitHub Actions Inactive
dmurphy18
dmurphy18 previously approved these changes May 22, 2023
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 22:18 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 22:18 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 22, 2023 22:18 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 00:59 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 00:59 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 00:59 — with GitHub Actions Inactive
It needs special work on the golden images to get SSL to properly work.
These steps are required because the code being tested is using
`easy_install` which does not know how to get certificates from `certifi`.
Since `easy_install` is too old, and deprecated, the extra work is not
worth it, plus, they are still being tested on other platforms.

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch force-pushed the hotfix/golden-images-3006.x branch from 48eb354 to 4feabfb Compare May 23, 2023 06:01
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 06:23 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 06:24 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 06:24 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 09:18 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 09:18 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch temporarily deployed to ci May 23, 2023 09:18 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch merged commit bc93320 into saltstack:3006.x May 23, 2023
303 checks passed
@s0undt3ch s0undt3ch deleted the hotfix/golden-images-3006.x branch May 23, 2023 12:33
s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request May 24, 2023
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
garethgreenaway pushed a commit that referenced this pull request May 24, 2023
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants