Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] nightly repos - version build numbers make automated installs of nightlys difficult #64927

Closed
ITJamie opened this issue Aug 4, 2023 · 4 comments · Fixed by #64929
Closed
Assignees
Labels
Bug broken, incorrect, or confusing behavior

Comments

@ITJamie
Copy link
Contributor

ITJamie commented Aug 4, 2023

Description
nightly repos do not have a sane version syntax that can be assumed,
adding a symlink from "minor/latest" to "minor/{build_version}" will fix the issue. otherwise scraping of the folder is needed for automated installs

Additional context
previous pr allowed us to get further down the nightly install chain (#64907)

@OrangeDog
Copy link
Contributor

Is this part of #64917?

@ITJamie
Copy link
Contributor Author

ITJamie commented Aug 8, 2023

Is this part of #64917?

no thats a separate issue

@ITJamie ITJamie changed the title [BUG] nightly repos - repometadata files contain invalid url [BUG] nightly repos - version build numbers make automated installs of nightlys difficult Aug 8, 2023
@anilsil anilsil added this to the Sulfur v3006.3 milestone Aug 9, 2023
@s0undt3ch
Copy link
Collaborator

Bare with me.
We both agree that the current nightly, if you always want to latest nightly is cumbersome.

How about, taking https://repo.saltproject.io/salt-dev/3006.x/latest as the base URL:

salt/py3/debian/11/amd64/latest -> salt/py3/debian/11/amd64/minor/3006.1+298.g08482ed6f3/
salt/py3/redhat/8/x86_64/latest -> salt/py3/redhat/8/x86_64/minor/3006.1+298.g08482ed6f3/

Then salt/py3/redhat/8/x86_64/latest.repo is either a link to salt/py3/redhat/8/x86_64/minor/nightly.repo or a separate one, which would point to salt/py3/redhat/8/x86_64/minor/<salt-version> ...

Thoughts?

@ITJamie
Copy link
Contributor Author

ITJamie commented Aug 11, 2023

That works for me. But we need to be 100% certain that the links inside that latest.repo are actually pointing to the latest path instead of the builddate/version numbered paths. Since those files get downloaded only once (hence me making the pr with the extra file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment