-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cp.push saved file crashed #6495
Comments
did further test, move same tar.gz to another server (which is success on another file cp.push), cp.push failed again. |
So does this only affect gzipped files? |
No , I test push the unzipped file, a plain SQL dump file, still crashed. On 03/08/2013, at 3:35 AM, David Boucha notifications@github.com wrote:
|
When you say "crashed", what do you mean by this? Is there a traceback? If so, please post it. Also, please post the output of |
I've confirmed this bug in develop The original file:
The file after being pushed to the master:
|
Another problem I noticed here is that, if the |
Additionally, it seems that when file_recv is not set, the minion still sends the file up to the master. Here's debug output from the master:
|
Looks you reproduced the bug, anyway, put my version report and hope it help. As I used cp.push in 2 different server for daily backup, looks the problem related to file size. The smaller one always success. The large one >10M fail always. |
@GeniusWiki Thanks! But can you clarify further what you mean by the cp.push "crashing"? |
Just md5sum checking failed and gunzip failed, same as your test... |
OK. I was just concerned that there were tracebacks I wasn't catching. I found a traceback when no file_recv option is set in the master config file, which I have fixed. Thanks for the report, we'll look into this. |
I confirmed my configuration: |
Yeah, the issue that caused the traceback I found earlier is that there was no default value when file_recv isn't included in the master config file. |
Wondering what the word is on this one? I tried the same thing: |
I think this issue has just been lost in the shuffle. Thanks for bumping it, it's still on our radar, just so many issues currently! =) |
I've found and fixed the problem. That was a tricky one, but once I tracked it down the solution was pretty easy. |
Command looks this:
salt 'db-01' cp.push /var/backups/some.tar.gz
The file downloaded has same size, but the md4sum is different. And gunzip cannot unzip - the original file can be unzipped.
I test same command in other server but different gzip files, looks fine.
I also test this command in same server but a small text file, looks fine as well...
The text was updated successfully, but these errors were encountered: