Problems with mounting

[jcollie]

I have a fairly simple sls to mount a NFS volume from a NetApp:

nfs-utils:
   pkg.installed

 /srv:
   mount.mounted:
    - device: 10.6.16.72:/vol/Web09
    - fstype: nfs
    - opts: vers=3
    - persist: True
    - require:
       - pkg: nfs-utils

This worked fine until 0.16.2, now I get:

----------
    State: - mount
    Name:      /srv
    Function:  mounted
        Result:    False
        Comment:   An exception occurred in this state: Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/salt/state.py", line 1239, in call
    ret = self.states[cdata['full']](*cdata['args'])
   File "/usr/lib/python2.7/site-packages/salt/states/mount.py", line 109, in mounted
    if ret['changes']['mount']:
KeyError: 'mount'

        Changes:   

Seems likely that this is related to commit 0c9bcab

[terminalmage]

@jcollie Thanks for the report. I've fixed this in #6526.

[jcollie]

With the patch in dd1d075 the traceback is avoided, but there's still a problem:

----------
    State: - mount
    Name:      /srv
    Function:  mounted
        Result:    False
        Comment:   Target was already mounted. Unfortunately the file system didn't exist.
        Changes:   

As you can see the filesystem is mounted (correctly):

# mount | grep /srv
10.6.16.72:/vol/Web09 on /srv type nfs (rw,relatime,vers=3,rsize=65536,wsize=65536,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,mountaddr=10.6.16.72,mountvers=3,mountport=4046,mountproto=udp,local_lock=none,addr=10.6.16.72)

This should be backported to 0.16 as well once this is well and truly fixed.

[basepi]

This has now been fixed properly in #6566.