Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add python modules needed for included core salt modules to onedir install #66091

Open
cheribral opened this issue Feb 18, 2024 · 1 comment
Assignees
Labels
Bug broken, incorrect, or confusing behavior

Comments

@cheribral
Copy link

Some renderers are supplied by default but the modules needed for them to work are not. As an example, we make substantial use of Mako, but during the transition to onedir and now when bringing up new minions we have run into many issues because the highstates fail hard without the Mako module being installed.

We have tried various things to work around this like injecting scheduled tasks before updates which try to fix minions after updates etc., but this does not always work.

It would be nice if the python modules needed for all the core salt modules would be included within the onedir installation. Not including all the possible modules made sense before when so many modules came with salt, but now that the number of things considered "core" have been better defined and reduced to manageable levels, it seems that making all the included things work out of the box would be a good idea.

P.S. The github template for these issues still refer to SEP which has been depreciated.

@cheribral cheribral added Feature new functionality including changes to functionality and code refactors, etc. needs-triage labels Feb 18, 2024
@dwoz dwoz added Feature new functionality including changes to functionality and code refactors, etc. Bug broken, incorrect, or confusing behavior and removed Feature new functionality including changes to functionality and code refactors, etc. needs-triage labels Feb 19, 2024
@dwoz dwoz added this to the Sulfur v3006.7 milestone Feb 19, 2024
@dwoz dwoz self-assigned this Feb 19, 2024
@ITJamie
Copy link
Contributor

ITJamie commented Feb 19, 2024

Id also argue that a few "sane" additions should be made

Eg pygit in salt-master package

@dwoz dwoz modified the milestones: Sulfur v3006.7, Sulfur v3006.9 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior
Projects
None yet
Development

No branches or pull requests

3 participants