Update the parser options with values from config file. Fixes #8447. #9040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck#8447. The way the parser merges the CLI configuration with the file configuration is. For each option: 1. If a value was passed to the CLI, that value rules. 2. If not value was passed to the CLI and no value is defined in the config file. The default, it any, is used. 3. If a value is not passed to the CLI and the value is defined in the config file, the config file one will be used. Some code was using the parser options for logic and values after the configuration loaded, but the parser options were never updated to the configuration files values. So: 4. Do what we said in the above 3, **and**, update the parser option to have that value.
|
Tagging @cachedout. |
thatch45
added a commit
that referenced
this pull request
Dec 6, 2013
…igfile-not-respected Update the parser options with values from config file. Fixes #8447.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the parser merges the CLI configuration with the file configuration is.
For each option:
Some code was using the parser options for logic and values after the configuration loaded, but the parser options were never updated to the configuration files values.
So: