eauth failure with batching

[djs52]

If a batch size is set, external auth gives a backtrace, regardless of whether a token is available:

$ salt -T -a pam '*' test.ping
server1:
  True
server2:
  True
...

But:

$ salt -b 2 -T -a pam '*' test.ping
[ERROR   ] An un-handled exception was caught by salt's global exception handler:
EauthAuthenticationError: Failed to authenticate, is this user permitted to execute commands?
Traceback (most recent call last):
  File "/usr/bin/salt", line 10, in <module>
    salt_main()
  File "/usr/lib/pymodules/python2.7/salt/scripts.py", line 117, in salt_main
    client.run()
  File "/usr/lib/pymodules/python2.7/salt/cli/__init__.py", line 61, in run
    batch = salt.cli.batch.Batch(self.config)
  File "/usr/lib/pymodules/python2.7/salt/cli/batch.py", line 24, in __init__
    self.minions = self.__gather_minions()
  File "/usr/lib/pymodules/python2.7/salt/cli/batch.py", line 43, in __gather_minions
    for ret in self.local.cmd_iter(*args):
  File "/usr/lib/pymodules/python2.7/salt/client/__init__.py", line 522, in cmd_iter
    **kwargs)
  File "/usr/lib/pymodules/python2.7/salt/client/__init__.py", line 230, in run_job
    return self._check_pub_data(pub_data)
  File "/usr/lib/pymodules/python2.7/salt/client/__init__.py", line 178, in _check_pub_data
    'Failed to authenticate, is this user permitted to execute '
EauthAuthenticationError: Failed to authenticate, is this user permitted to execute commands?

[basepi]

Good to know. I'm sure it's just an oversight with the way that batch mode was added. We'll get it fixed.

[Rucknar]

Stupid question perhaps, how come this hasn't yet made it out the door into a release yet? Batch mode is broken in our environment :(

[basepi]

Nah, not stupid. Nobody pinged me on the pull request to cherry-pick it, so I never cherry-picked it into the 2014.1 branch. In the future, if there are pull requests you think need to make it into the next bugfix release, please ping me (@basepi) on the pull request and I'll apply the appropriate label. I have applied the label in this case, this should be in 2014.1.6.

[Rucknar]

Excellent, much appreciated :)

[basepi]

FYI, this broke things in 2014.1 as it requires additional code that's not in 2014.1. We have reverted for the 2014.1.7 release, so I apologize but you'll have to wait until the next feature release to get this fix. (Luckily, that feature release is scheduled for a release candidate next week!)

[Rucknar]

Thanks for the update, will keep an eye out for it and use other methods of authentication for now.

[basepi]

Thanks, and sorry for the inconvenience.