Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tide.py #4

Open
sam-cox opened this issue Mar 22, 2014 · 1 comment
Open

Refactor tide.py #4

sam-cox opened this issue Mar 22, 2014 · 1 comment

Comments

@sam-cox
Copy link
Owner

sam-cox commented Mar 22, 2014

This is definitely the messiest module, although to some extent that's because it's the most complex. It would be nice if it was a little more pythonic - I'd like it to read more like pseudocode. There are also some rather long lines, and fairly long methods. Could probably also do with factoring out the isinstance stuff which lets you pass datetimes or hours and values or lists of values etc.

@naught101
Copy link

Before refactoring, it would be worth running it through pylint/flake8. Python code shouldn't use tabs, and there are some other whitespace issues like spaces after #s that it would make sense to deal with first, in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants