Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x64 support and new win32-win64 output directories #58

Closed
wants to merge 2 commits into from

Conversation

robertolarcher
Copy link

I'd like to submit some modifications that enable x64 support. Output files, both deliverables (.dll, .lib etc), and intermediates (.obj) are in win32 and win64 directories.

win32win64

win32

x64 dll has been tested on Windows 10 technical preview

win32/readme.txt Outdated
@@ -0,0 +1 @@
placeholder for win32 compiled files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't the batch files create these output directories?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure. Let me do some tests.
[EDIT] done

@sam-github
Copy link
Collaborator

I'd like to run it before merge, it will take me a couple days before I get some time.

other minor changes:
msvcbuild.bat renamed msvcbuild32.bat
placeholders for win32 and win64 dirs removed
@robertolarcher
Copy link
Author

Hi,
any news about this pull?

#58

Best regards
Roberto

Date: Mon, 16 Mar 2015 12:13:19 -0700
From: notifications@github.com
To: libnet@noreply.github.com
CC: robertolarcher@hotmail.com
Subject: Re: [libnet] x64 support and new win32-win64 output directories (#58)

I'd like to run it before merge, it will take me a couple days before I get some time.


Reply to this email directly or view it on GitHub.

@gvanem
Copy link

gvanem commented Aug 24, 2015

IMHO, it would be make more sense to put the .obj-files under

<libnet-root>\libnet\src\[Win32|Win64]\[Release|Debug]

This seems more like MSbuild does it if a .sln/.vcxproj file was used.

And have your .bat-files name the libraries as:

<libnet-root>\libnet\lib\[x86|x64]\libnet*.lib
<libnet-root>\libnet\lib\[x86|x64]\libnet*.dll

But the .bat-files are not very nice. I.e. they breaks e.g. a MingW build by copying <stdint.h> into the include-path. How about an #ifdef _MSC_VER inside libnet.h instead?

sgeto added a commit to sgeto/libnet that referenced this pull request Nov 17, 2016
improved MSVC x64 support suggested by robertolarcher (Pull Request libnet#58), README.win32 adjustments, added (Linux only) Travis test yml as well as other tiny fixes.
sam-github pushed a commit that referenced this pull request Jun 5, 2018
improved MSVC x64 support suggested by robertolarcher (Pull Request #58), README.win32 adjustments, added (Linux only) Travis test yml as well as other tiny fixes.
sgeto added a commit to sgeto/libnet that referenced this pull request Jun 9, 2018
improved MSVC x64 support suggested by robertolarcher (Pull Request libnet#58), README.win32 adjustments, added (Linux only) Travis test yml as well as other tiny fixes.
@troglobit
Copy link
Collaborator

Long time no progress on this PR. This was referenced in #65, which has now been merged so I'm closing this PR. If there are any outstanding issues, please submit a new PR.

@troglobit troglobit closed this Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants