New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x64 support and new win32-win64 output directories #58
Conversation
win32/readme.txt
Outdated
@@ -0,0 +1 @@ | |||
placeholder for win32 compiled files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't the batch files create these output directories?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure. Let me do some tests.
[EDIT] done
I'd like to run it before merge, it will take me a couple days before I get some time. |
other minor changes: msvcbuild.bat renamed msvcbuild32.bat placeholders for win32 and win64 dirs removed
Hi, Best regards Date: Mon, 16 Mar 2015 12:13:19 -0700 I'd like to run it before merge, it will take me a couple days before I get some time. — |
IMHO, it would be make more sense to put the .obj-files under
This seems more like MSbuild does it if a .sln/.vcxproj file was used. And have your .bat-files name the libraries as:
But the .bat-files are not very nice. I.e. they breaks e.g. a MingW build by copying |
improved MSVC x64 support suggested by robertolarcher (Pull Request libnet#58), README.win32 adjustments, added (Linux only) Travis test yml as well as other tiny fixes.
improved MSVC x64 support suggested by robertolarcher (Pull Request #58), README.win32 adjustments, added (Linux only) Travis test yml as well as other tiny fixes.
improved MSVC x64 support suggested by robertolarcher (Pull Request libnet#58), README.win32 adjustments, added (Linux only) Travis test yml as well as other tiny fixes.
Long time no progress on this PR. This was referenced in #65, which has now been merged so I'm closing this PR. If there are any outstanding issues, please submit a new PR. |
I'd like to submit some modifications that enable x64 support. Output files, both deliverables (.dll, .lib etc), and intermediates (.obj) are in win32 and win64 directories.
x64 dll has been tested on Windows 10 technical preview