Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign In with Apple ID #8

Open
awhitford opened this issue Feb 28, 2020 · 13 comments
Open

Sign In with Apple ID #8

awhitford opened this issue Feb 28, 2020 · 13 comments
Assignees
Labels
enhancement New feature or request

Comments

@awhitford
Copy link

How easy is it to add Sign In with Apple ID? (See Apple App Store requirement.)

@sam0829
Copy link
Owner

sam0829 commented Mar 2, 2020

Hi @awhitford , It seems native Firebase UI for iOS has this so it'll be easy for iOS. I am not sure about Android ATM. I'll try to check and integrate if it's possible :)

@sam0829 sam0829 self-assigned this Mar 2, 2020
@sam0829 sam0829 added the enhancement New feature or request label Mar 2, 2020
@robmr88
Copy link

robmr88 commented Mar 20, 2020

Thank you, I would also need for Login with Apple ID to be available if possible. Apple store turns back apps sometimes it it notices you are using different login methods but not Apple ID.

@robmr88
Copy link

robmr88 commented Mar 28, 2020

Hi, do you think you can give an estimated date for Apple login on iOs ? It would be so helpful . Apple is asking for Apple login on apps to be mandatory now

@sam0829
Copy link
Owner

sam0829 commented Mar 28, 2020

Hi @robmr88, Sorry I am quite busy lately with other stuff. I'll try to integrate it over the next week :)

@robmr88
Copy link

robmr88 commented Apr 3, 2020

That would be great, thank you

@robmr88
Copy link

robmr88 commented Apr 11, 2020

Any chance of having Apple login soon ? :D

@fdietze
Copy link
Contributor

fdietze commented Apr 11, 2020

If it's so urgent, I suggest you add it yourself and make a PR. It's very straight-forward, since this library is just a wrapper of the iOS and android libraries. Have a look where facebook appears in the code:
https://github.com/sam0829/firebase_auth_ui/search?q=facebook
Then add the corresponding code for Apple.

@robmr88
Copy link

robmr88 commented Apr 21, 2020

I have literally 0 experience with iOs development, I will give it a try but once I have the code I wouldn't know where to start.
I will try, hoping in the meantime the update of the library will come :D

@kinex
Copy link

kinex commented Jun 4, 2020

Any plans to implement this by 30th June? Please notice that without "Sign in with Apple" this library is not usable anymore for existing apps after 30th June. Apple will already reject new apps using this library (based on info here).

In my opinion supporting this on iOS has higher priority, you could implement support for Android later if it requires more work.

@sam0829
Copy link
Owner

sam0829 commented Jun 8, 2020

Hi everyone, I've started working on adding this feature and I've completed adding sign in with Apple for iOS. However, there's one open issue in underlying native SDK which doesn't return displayName after the first sign up. I'll try to have a workaround for this and release the new update ASAP.

@robmr88
Copy link

robmr88 commented Jun 17, 2020

thanks, hope you can make it in time :D
also, if you have time could you check the logo for Android ?
I put an image in drawable folder with name auth_ui_logo.png but it doesn't appear

@pvcorazza
Copy link

Hi, any updates on that?

@rndsamjin
Copy link

has there been an update to login using apple id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants