To-do-list: List Structure #1
Conversation
mrsamsharma
commented
Jul 6, 2022
mrsamsharma
commented
- Used webpack environment to build this project
- Create an array with desc, boolean, index and rendered it's content dynamically into the document using javascript
There was a problem hiding this comment.
Hi @samWfelice,
Good job so far! 👍🏻
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| tasks.forEach((each) => { | ||
| const taskList = document.createElement('li'); | ||
| taskList.className = 'list'; | ||
| const taskLabel = document.createElement('label'); | ||
| taskLabel.className = 'list-label'; | ||
| taskLabel.setAttribute('for', each.index); |
There was a problem hiding this comment.
- Please make sure to display the list of todos after sorting them by their index value first, as per this requirements.
There was a problem hiding this comment.
Hi @samWfelice,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- No linter errors. ✔️
- GitHub flow is followed. ✔️
- PR has a good summary. ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
@roshan-bajgain Please kindly check again since there are no linter errors! |
