Add coverage task #1422
Closed
Add coverage task #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the simplecov gem to vendors and a corresponding rake task to generate a coverage report. To generate the report, assuming we're in the app/server/sonicpi directory, we just need to type 'rake coverage', and the html report output is generated into app/server/sonicpi/coverage.
The tests were being run twice previously. The first time they run normally, but the second time the test framework appears to run again with zero tests. This wasn't really a huge problem when running just the tests, but prevented coverage from being generated as the second zero tests run would overwrite the coverage output. This change prevents this.
ethancrawford
force-pushed
the
add_coverage_task
branch
from
bbdbf44
to
948d9dd
Compare
|
@ethancrawford do you have an example of a report produced by this on the Sonic Pi codebase? |
|
@samaaron - not a current one but I'll generate one asap. |
|
Looks like stale |
|
Apologies, we've now moved our default branch from master to main. Please consider creating a new pull request merging with main with these changes. I am closing this not out of any lack of interest, but in order to ensure new code moves to our new default branch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the simplecov gem to vendors and a corresponding rake task to generate a coverage report.
To generate the report, assuming we're in the app/server/sonicpi directory, we just need to type
rake coverage, and the html report output is generated into app/server/sonicpi/coverage.