Add current line indication #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be possible to use QScintilla's marker system for this. Example in PyQt: http://eli.thegreenplace.net/2011/04/01/sample-using-qscintilla-with-pyqt Docs for QsciScintilla::markerDeleteAll http://pyqt.sourceforge.net/Docs/QScintilla2/classQsciScintilla.html#a52aaeee4b9171222c20af3557adaf0ad Docs for QsciScintilla::markerAdd http://pyqt.sourceforge.net/Docs/QScintilla2/classQsciScintilla.html#a12673046e00bd7fdd7616a5e8c62a924
This adds a line marker into the GUI for `play` and `sample` commands. It probably needs it's own osc endpoint. Also need to address what to do with multiple threads in a workspace (probably using thread_id somehow) and what to do with error messages in terms of marking the line of the error.
|
I'm going to close this because I think Sam has basically implemented what's here already in v2.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a line marker into the GUI for
playandsamplecommands.It probably needs it's own osc endpoint. Also need to address what to do
with multiple threads in a workspace (probably using thread_id somehow)
and what to do with error messages in terms of marking the line of the
error.