Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual instance creation of NetcoreWhatsappAdapter #49

Closed
chinmoy12c opened this issue May 1, 2023 · 0 comments · Fixed by #50
Closed

Remove manual instance creation of NetcoreWhatsappAdapter #49

chinmoy12c opened this issue May 1, 2023 · 0 comments · Fixed by #50
Assignees
@chinmoy12c

Comments

@chinmoy12c
Copy link
Member

Manual instance creation leads to tight coupling and makes testing difficult, we need to remove this manual instance creation and let Spring boot handle the instance as a bean.

Part of samagra-comms/adapter#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chinmoy12c chinmoy12c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup/remove netcore whatsapp adapter manual instance creation chinmoy12c/inbound
1 participant
@chinmoy12c