Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dependencies and various changes #13

Merged
merged 7 commits into from Apr 27, 2020
Merged

Updated dependencies and various changes #13

merged 7 commits into from Apr 27, 2020

Conversation

Nicuz
Copy link
Contributor

@Nicuz Nicuz commented Apr 22, 2020 •
edited

Hi Samarth, these are the changes I made:

  • updated dependencies
  • added error handling for GET requests
  • explicit data types
  • doc comments for a better comprehension
  • updated full example

@samarthagarwal
Copy link
Owner

Sorry, I haven't been getting much time to test your commits. Allow me some time to do this.

@samarthagarwal samarthagarwal merged commit 2b27d92 into samarthagarwal:master Apr 27, 2020
@samarthagarwal
Copy link
Owner

Thank you for your contribution @Nicuz .

@Nicuz
Copy link
Contributor Author

Nicuz commented Apr 27, 2020

Thanks to you, this package saved me a lot of time! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nicuz @samarthagarwal