Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use "ECMASCRIPT5" or "ECMASCRIPT5_STRICT" as values for closureLanguage #71

Closed
smartboyathome opened this issue Aug 22, 2014 · 3 comments
Assignees
Labels
Milestone

Comments

@smartboyathome
Copy link

I am using version 1.7.3 of your plugin with the closure compiler, and when I specify either "ECMASCRIPT5" or "ECMASCRIPT5_STRICT" as the value of closureLanguage, it fails to compile, outputting "com.google.javascript.jscomp.CompilerOptionsValidator$InvalidOptionsException: Can only convert code from ES6 to ES3. Cannot convert from ECMASCRIPT5 to ECMASCRIPT3." The ant compiler had a similar problem (see google/closure-compiler#566) and they solved it by adding the ability to specify ES6/ECMASCRIPT6. It would be nice if you could add this as well.

@smartboyathome
Copy link
Author

Forcing a newer version of the closure compiler via below solved the problem for me:

 <plugin>
    <groupId>com.samaxes.maven</groupId>
    <artifactId>minify-maven-plugin</artifactId>
    <version>1.7.3</version>
    <dependencies>
        <dependency>
            <groupId>com.google.javascript</groupId>
            <artifactId>closure-compiler</artifactId>
            <version>v20140814</version>
        </dependency>
    </dependencies>
    <executions>
        ...
    </executions>
</plugin>

If you could update the version provided that would prevent others from running into this.

@samaxes
Copy link
Owner

samaxes commented Aug 23, 2014

Thanks for the update.
I'll try to upload a new version this weekend or during next week.

@samaxes samaxes added bug and removed bug labels Aug 25, 2014
@samaxes samaxes added this to the 1.7.4 milestone Aug 25, 2014
@samaxes samaxes self-assigned this Aug 25, 2014
@samaxes
Copy link
Owner

samaxes commented Aug 25, 2014

Pushed into master branch.

@samaxes samaxes closed this as completed Aug 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants