Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The time step t is not used? #10

Closed
PanXiebit opened this issue Apr 20, 2022 · 2 comments
Closed

The time step t is not used? #10

PanXiebit opened this issue Apr 20, 2022 · 2 comments

Comments

@PanXiebit
Copy link

def forward(self, idx, t=None):

The denoise_fn is Transformer, but in the forward of this model, the time step t is not used?

@samb-t
Copy link
Owner

samb-t commented Apr 20, 2022

Hi, yes that's correct. In our early experiments we tested the impact of conditioning the Transformer on time but didn't find it to have much of an effect.

My guess as to why this doesn't matter so much in the discrete absorbing diffusion case is that it's relatively simple for the model to figure out what the time step is based on the number of input tokens that are masks. Whereas in the continuous Gaussian case it's much less obvious how noisy the inputs are.

Hope this helps!

@PanXiebit
Copy link
Author

@samb-t Thanks a lot! This really helps.

@samb-t samb-t closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants