Background colour defaults to border colour with more transparency wh… #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started using this package, but it looks like
options.fill
doesn't behave as expected (at least according to my interpretation, which could be wrong).Current functionality: When
options.fill
is set to something, the graphs do not render with a fill colour unless the user also specifically defines an array of colours for thebackgroundColor
property. This is contrary to the behaviour of theborderColor
property which conveniently defaults to a 'random' colour for the user.Proposed Functionality: When a user sets a value for options.fill, the
backgroundColor
property should default to a more transparent version of the border colour chosen for that data set. This is consistent with normal Graphana behaviour.I have made a modification to the code that does this after setting
options.fill
to any Javascript 'truthy' value. It uses the existing commented out fill colours that are, in my eyes, were a good amount of 'more transparent'