Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background colour defaults to border colour with more transparency wh… #17

Merged
merged 1 commit into from Apr 16, 2022

Conversation

jbarkovic
Copy link
Contributor

I started using this package, but it looks like options.fill doesn't behave as expected (at least according to my interpretation, which could be wrong).

Current functionality: When options.fill is set to something, the graphs do not render with a fill colour unless the user also specifically defines an array of colours for the backgroundColor property. This is contrary to the behaviour of the borderColor property which conveniently defaults to a 'random' colour for the user.

Proposed Functionality: When a user sets a value for options.fill, the backgroundColor property should default to a more transparent version of the border colour chosen for that data set. This is consistent with normal Graphana behaviour.

I have made a modification to the code that does this after setting options.fill to any Javascript 'truthy' value. It uses the existing commented out fill colours that are, in my eyes, were a good amount of 'more transparent'

@samber
Copy link
Owner

samber commented Apr 16, 2022

Thanks for the report. 👌

Let's merge.

@samber samber merged commit 099d443 into samber:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants