Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shutdown all services even on error #42

Closed
danilobuerger opened this issue Aug 29, 2023 · 3 comments
Closed

shutdown all services even on error #42

danilobuerger opened this issue Aug 29, 2023 · 3 comments

Comments

@danilobuerger
Copy link

Currently when Injector.Shutdown receives an error while calling Shutdown on a service, it aborts and never calls Shutdown on the following services. It would be nice to have it behave like Injector.HealthCheck were all services are called regardless of their returned errors.
@happyyi008
Copy link

Also when a service's shutdown function panics it would be nice to be able to recover from that error and finish up shutdown for other services.

@danilobuerger
Copy link
Author

@samber any chance we can discuss this? I would PR it if you are open to the change!

@christiandins christiandins mentioned this issue Oct 12, 2023
Closed
@samber
Copy link
Owner

samber commented Dec 31, 2023

Fixed in v2 -> #45

@samber samber closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danilobuerger @samber @happyyi008