Error on tree containers inserting element with hint iterator

[bpinzone]

Bug Report

Summary

• TSTL Version: 2.2.0
• Expected behavior: Set union should succeed then log 1, 2.
• Actual behavior: Uncaught exception occurs.

Code incurring the bug

import std = require("tstl");
function test_tstl(){
    let Set1: set<number> = new set<number>()
    let Vector1: vector<number> = new vector<number>()

    Vector1.push_back(1)
    Vector1.push_back(2)

    set_union(Set1.begin(), Set1.end(), Vector1.begin(), Vector1.end(), inserter(Set1, Set1.end()))

    for(let it = Set1.begin(); !it.equals(Set1.end()); it = it.next()){
        console.log(it.value)
    }

}

Stack Trace

Uncaught Exception:
TypeError: Cannot read property 'valueOf' of undefined
    at less (/node_modules/tstl/functional/comparators.js:43:11)
    at _UniqueSetTree.nearest_by_key (/node_modules/tstl/base/tree/_UniqueSetTree.js:49:32)
    at _UniqueSetTree._SetTree.lower_bound (/node_modules/tstl/base/tree/_SetTree.js:72:25)
    at TreeSet.lower_bound (/node_modules/tstl/container/TreeSet.js:100:27)
    at TreeSet.UniqueTreeSet._Insert_by_key (/node_modules/tstl/base/container/UniqueTreeSet.js:69:23)
    at TreeSet.UniqueTreeSet._Insert_by_hint (/node_modules/tstl/base/container/UniqueTreeSet.js:88:25)
    at TreeSet.SetContainer.insert (/node_modules/tstl/base/container/SetContainer.js:117:25)
    at TreeSet.UniqueSet.insert (/node_modules/tstl/base/container/UniqueSet.js:65:40)
    at InsertIterator.set [as value] (/node_modules/tstl/iterator/InsertIterator.js:48:29)
    at Object.copy (/node_modules/tstl/algorithm/modifiers.js:46:22

Desirable Behavior as in C++

int main() {
    set<int> Set1;
    vector<int> Vector1;

    Vector1.push_back(1);
    Vector1.push_back(2);

    set_union(Set1.begin(), Set1.end(), Vector1.begin(), Vector1.end(), inserter(Set1, Set1.end()));

    for(auto it = Set1.begin(); it != Set1.end(); ++it){
        cout << *it << endl;
    }
    // outputs "1\n2\n"

    return 0;
}

[samchon]

Thanks for your reporting. By your contribution, I could find an error returning invalid iterator when inserting element on tree based containers with hint iterator: TreeSet<T>.insert(hint: TreeSet.Iterator<T>, val: T).

66fadfa#diff-d7f3ab5398accffb17830e4643a8de65

I'm planning to publish the patch v2.2.1 on this weekend (maybe Sunday). If you can't wait the formal publish, you can consider the beta version:

npm install --save tstl@next