Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semaphore throws mis-described exceptions #55

Closed
samchon opened this issue Dec 12, 2019 · 0 comments
Closed

Semaphore throws mis-described exceptions #55

samchon opened this issue Dec 12, 2019 · 0 comments
Assignees
Labels
bug Something isn't working experimental Experimental Feature

Comments

@samchon
Copy link
Owner

samchon commented Dec 12, 2019

Summary

  • TSTL version: 2.3.0
  • Expected behavior: Exception message describes its source exactly
  • Actual behavior: Exception message contains the keyword experimental

Semaphore is no more experimental feature since v2.3 update. However, its exception messages are saying themselves are experimental features yet. It should be fixed

Code occuring the bug

if (count < 1)
throw new OutOfRange(`Error on std.experimental.Semaphore.release(): parametric count is less than 1 -> (count = ${count}).`);
else if (count > this.max_)
throw new OutOfRange(`Error on std.experimental.Semaphore.release(): parametric count is greater than max -> (count = ${count}, max = ${this.max_}).`);
else if (count > this.acquiring_)
throw new OutOfRange(`Error on std.experimental.Semaphore.release(): parametric count is greater than acquiring -> (count = ${count}, acquiring = ${this.acquiring_}).`);

Need to remove the message experimental

@samchon samchon added the bug Something isn't working label Dec 12, 2019
@samchon samchon self-assigned this Dec 12, 2019
@samchon samchon added the experimental Experimental Feature label Dec 12, 2019
@samchon samchon added this to To do in v2.3 Update Dec 12, 2019
@samchon samchon added this to To do in v2.4 Update Dec 12, 2019
@samchon samchon moved this from To do to In progress in v2.3 Update Dec 12, 2019
@samchon samchon moved this from To do to Done in v2.4 Update Dec 12, 2019
@samchon samchon moved this from In progress to Patch in v2.3 Update Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working experimental Experimental Feature
Projects
v2.4 Update
  
Done
v2.3 Update
  
Patch
Development

No branches or pull requests

1 participant