Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After assigning a text color - we need to get back to the default color #329

Closed
q2apro opened this issue Aug 8, 2014 · 7 comments
Closed

Comments

@q2apro
Copy link

q2apro commented Aug 8, 2014

When you select a text color and write the word, then want to deselect it, there is no option:

<p>
    Let us start to write. Now we assign a color before we write the colored word: <br />
</p>
<p>
    <span style="color: rgb(255, 0, 0);">red is assigned, let's deselect it<span style="color: rgb(0, 0, 0);"> oh I had to choose black as there is no &quot;default color&quot; option!</span></span><br />
</p>

Instead of the deselect - which is missing - I have to select the black color as default (black matches my default CSS color). This creates several color spans for black that are unnecessary.

I suggest to add a feature that CKEditor calls "automatic", we could call it "default":

example

It is important to prevent all the <span style="color: rgb(0, 0, 0);">. In a long text of one of my users there were about 20 occurences of this black-span.

@samclarke
Copy link
Owner

You can use the clear styling to reset the colour but you're right it could really do with an automatic option.

I also think reducing the number of default colours and increasing the box size might be a good idea too.

@q2apro
Copy link
Author

q2apro commented Aug 13, 2014

I also think reducing the number of default colours and increasing the box size

That is what I did here: http://www.gute-mathe-fragen.de/ask

capture

@samclarke samclarke added this to the v1.4.7 milestone Aug 14, 2014
@q2apro
Copy link
Author

q2apro commented Aug 17, 2014

Here is the screencast gif for the "color span bug":

sceditor-span-bug

@brunoais brunoais added Bug? and removed Bug? labels Aug 17, 2014
@q2apro
Copy link
Author

q2apro commented Oct 1, 2014

Meanwhile my users have generated 5440 posts containing multiple <span style="color: rgb(0, 0, 0)">...</span> tags. Kind of problematic.

Is there no solution, no workaround?

PS: I have also noticed that <br> tags get the color assigned: <br style="color: rgb(0, 0, 0)"> - This is definitely a bug.

@q2apro
Copy link
Author

q2apro commented May 26, 2015

Push: Is there any solution in sight?

@samclarke samclarke modified the milestones: v1.5.0, v1.6.0 Oct 13, 2016
@Eldenroot
Copy link

@samclarke - should be fixex ASAP, quite annoying!

@samclarke samclarke modified the milestones: v2.0.0, v2.1.0 Nov 5, 2017
@samclarke samclarke modified the milestones: v2.1.0, 2.2.0 Nov 20, 2017
@samclarke
Copy link
Owner

This seems to be two issues in one. The duplicate span tags issue is fixed by #804 and I've made a new issue for the automatic colour option (#858).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants