Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in forward() #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix race condition in forward() #3

wants to merge 3 commits into from
+29 −25

Conversation

arseneyr
Copy link

This PR depromisifies forward() by either passing it a port directly or via callback in serializePort().

Fixes #2

@arseneyr arseneyr mentioned this pull request Jul 29, 2020
Open
@WorldLanguages WorldLanguages mentioned this pull request Feb 24, 2021
Closed
@MindsightsAI
Copy link

@samdenty What's taking so long for this PR to hang? It fixes a really important problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues when awaiting proxy methods simultaneously
2 participants
@arseneyr @MindsightsAI