Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old logs and keeping new Logs #5

Closed
lchsam opened this issue Aug 15, 2018 · 1 comment
Closed

Removing old logs and keeping new Logs #5

lchsam opened this issue Aug 15, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@lchsam
Copy link

lchsam commented Aug 15, 2018

Hi,
I am trying to implement a logging component that incrementally deletes old logs when there are too many logs.
I noticed that console-feed does not rerender properly when I delete and add new logs.

Have a look at this example: https://codesandbox.io/s/x9wpm9w1vz
Try pressing the new log button.

Thanks!

@samdenty samdenty added the bug Something isn't working label Aug 15, 2018
@arthurdenner
Copy link
Contributor

The cause of this problem is that we are using the index as the key here.

I thought about using ${log.method}-${i} as the key, this may be enough to solve the problem.

@samdenty99, what do you think? I have a PR ready to submit if you agree with this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants