-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby 3.2 support #529
Comments
Hello, I use your Dockerfile in a Synology Nas via the integrated Docker Manager. |
@CSCSxx You should make your own issue... that's not what we discuss in this issue |
According to your title, your both requesting a newer version of Ruby. Unfortunately, 2.7 is the newest version of ruby in the brightbox/ruby-ng repo. Which means bumping the OS version, which cascades into a lot of other changes. I will try to bump it again, but it might turn into a project. |
Alright, this took way too long but I pushed a new branch, ruby3.2 that moves the 5.1.1 redmine to ruby 3.2. This ended up involving swapping to a Debian-based distro. So it would be good if people would try it out and see if it works before I merge it into master. I don't know anything about YJIT, does redmine support it? How do you even enable it? |
https://shopify.engineering/ruby-yjit-is-production-ready this should be nothing but platform agnostic change, meaning redmine doesn't specifically have to care about it. In order to turn it on and off, you just need to specify |
We tested the ruby3.2 branch and its working as expected. thanks. Could you please merge to master or create a new image out of it? Also we would like to point out the problem with attachments which will get saved in /redmine/files. this directory is not in sync with mounted volume /data/files. hence the data there are not persisted and attachments are getting lost once the new container brought up. |
eh? thats a huge problem. Though neither of those paths exist I'm going to assume your paraphrasing... |
So not sure what you mean, I just tested in the master branch and files were correctly persisted.
I also tested it on the ruby3.2 branch and had no issue with files persisting. |
sorry, my bad! i was expecting the attachment data to be in REDMINE_ROOT/files directory(/home/redmine/redmine/files). that is where our existing redmine stores the files. but things are clear now . thank you! |
@jcormier Thankyou for ruby support as most of the plugins we tried requires ruby 3.x. Could you please merge this branch to master or would you be able to push a seperate image with ruby tag. Thankyou |
Thanks for the bump, this has been dragging for quite a while. I'm still fairly swamped at work currently. I merged the ruby changes into master, and tagged 5.1.1-4. Docker images are building now. |
Sicne 5.1.0, Rubt 3.2 is supported and we can use
YJIT
properly.The text was updated successfully, but these errors were encountered: