Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

confused with the train process #31

Closed
lzwhard opened this issue Apr 8, 2019 · 4 comments
Closed

confused with the train process #31

lzwhard opened this issue Apr 8, 2019 · 4 comments

Comments

@lzwhard
Copy link

lzwhard commented Apr 8, 2019

Dear samet,

I think your ganomaly has no adversarial train.

you trained the Discriminator with |f(x) - f(x')|, (not the real or fake).

so I doubt that your D can not judge input is real or fake.

and your Generator using the real/fake (D have no idea about it) to adversarial the the autoencoder.

I have read your skip-ganomaly paper, there is the actual adversarial train.

@gdjmck
Copy link

gdjmck commented Apr 22, 2019

I have the same confusion as well, it seems that the classifier of the NetD are never modified and just stay as what it was initialized?

@lzzlxxlsz
Copy link

hello,have you run the code successfully ?

@samet-akcay
Copy link
Owner

Hi @lzwhard and @gdjmck,
As you pointed out, the previous version had some issues with the discriminator training. The updated code trains the discriminator in an adversarial setting. The feature matching loss |f(x) - f(x')| from discriminator is added to the generator training, which overall improves the performance of the model. Please check out the latest version, and let me know if you have any concerns.

@samet-akcay
Copy link
Owner

I'm closing this issue due to inactivity. If needed, the discussion could be continued in #28.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants