Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLN File no longer compiles #20

Closed
freeone3000 opened this issue Feb 20, 2022 · 2 comments
Closed

SLN File no longer compiles #20

freeone3000 opened this issue Feb 20, 2022 · 2 comments

Comments

@freeone3000
Copy link

The SLN file appears to be missing a reference to the lol/ directory as an include directory. In addition, the Win8.1 SDK (in contrast with the Win10 SDK) does not include float.h. As such, the project does not compile. I've attempted to retarget against Win10 SDK with build tools 137, but this did not solve the issue.

@samhocevar
Copy link
Owner

Thanks for reporting this. Unfortunately Visual Studio is not very smart and doesn’t understand that retargeting the project requires modifying Directory.Build.props rather than lolremez.vcxproj. I’ve fixed the issue in d0e62f8.

@vivienlonde
Copy link

Thanks for the fix. The reference to build tools v143 in lolremez.vcxproj versus v142 in Directory.Build.props made the project not compile on my machine (windows). Referring to v142 everywhere fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants