Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken due to HTML change #4

Closed
wooziwoozi opened this issue Nov 21, 2023 · 7 comments
Closed

Broken due to HTML change #4

wooziwoozi opened this issue Nov 21, 2023 · 7 comments
Assignees
Labels

Comments

@wooziwoozi
Copy link

I just installed this, and saw a review on the Mozilla add on store saying it worked 5 days ago, so i thought I would make a post here.

This is how it looks for me:
Screencap 003 - 2023-11-20

Even on comments that are not spam.

@samipfjo samipfjo self-assigned this Nov 21, 2023
@samipfjo samipfjo added bug Something isn't working critical Essential feature is broken labels Nov 21, 2023
@samipfjo
Copy link
Owner

Thanks for the bug report! I bet YouTube changed something; I'll have to check it out. I'm fairly bogged down by work at the moment but I'll take a look as soon as possible.

@samipfjo
Copy link
Owner

samipfjo commented Dec 2, 2023

Here's an update on the issues at hand for anyone passing by.

Two changes have been made that are preventing the extension from working.

The first was an easy fix and I just pushed a patch for it. YouTube tweaked the HTML structure of comments.

The second is a bit harder. I'm unclear on exactly what happened, but it appears that the ways that browsers are allowing the WebGPU API to be accessed has changed. This broke access to TensorFlow's GPU acceleration, which OpenNSFW.js depends on to run at a good speed while not metaphorically setting users' devices on fire by running on the CPU. YouTube Spam Remover relies on for OpenNSFW.js for nudity detection, so this issue subsequently breaks YTSR. The unfortunate news is that I'm also the author of OpenNSFW.js (I wrote it for this extension!), so it's on me to fix this on both ends 🙃.

I'm gonna do my best to get the patch pushed out as promptly as I can now that I have a moment to breathe.

@samipfjo
Copy link
Owner

samipfjo commented Dec 6, 2023

Okay, fortunately the OpenNSFW.js issue was very straightforward and I just pushed a patch. My test builds of YTSR appear to be working again; I'll get the new version pushed out to the extension shops ASAP. Mozilla is usually pretty quick about clearing new versions for release. It will get pushed out to all users once y'all's browsers decide it's time to check for updates.

I'll post here again once the update has cleared and will mark the issue as resolved at that point, though I think I'll keep it open for a week or so until all users will has most likely gotten the patch.

@samipfjo
Copy link
Owner

samipfjo commented Dec 7, 2023

Update is live on both the Mozilla and Chrome extension stores!

@wooziwoozi
Copy link
Author

Thank you! I will try it out :)

@samipfjo samipfjo added Resolved and removed bug Something isn't working critical Essential feature is broken labels Dec 7, 2023
@samipfjo samipfjo changed the title Not working Broken due to HTML change Dec 7, 2023
@nascentt
Copy link

nascentt commented Mar 2, 2024

somehow this is both open and resolved.

@samipfjo
Copy link
Owner

samipfjo commented Mar 6, 2024

somehow this is both open and resolved.

Thanks for letting me know. I had left it open keep it visible in case someone else came by for the same reason. It's been pretty long enough that this is no longer relevant.

@samipfjo samipfjo closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants