ARGS: parameter not set - make ARGS optional

[Misiu]

Hi there,
recent version adds support for ARGS parameter, but if someone isn't using it then the deploy won't work.
I get this error:

Starting FTP Deploy
Uploading files...
/entrypoint.sh: line 12: ARGS: parameter not set

I use Your action like so:

    - name: FTP Deploy
      uses: SamKirkland/FTP-Deploy-Action@master
      env: 
       FTP_SERVER: ${{ secrets.FTP_SERVER }}
       FTP_PASSWORD: ${{ secrets.FTP_PASSWORD }}
       FTP_USERNAME: ${{ secrets.FTP_USERNAME }}
       REMOTE_DIR: ${{ secrets.REMOTE_DIR }}
       LOCAL_DIR: ${{ secrets.LOCAL_DIR }}

Can ARGS be optional?

[jcolls]

Not sure if it's related but I'm getting the following error regarding Docker on the FTP-Deploy-Action step following this update.

/entrypoint.sh: line 12: ARGS: parameter not set
Starting FTP Deploy
Uploading files...
##[error]Docker run failed with exit code 2

update: I added ARGS --delete to my action and it completed successfully.

[Misiu]

@jcolls yes, but this will remove all existing files on Your FTP, as I workaround I added --no-empty-dirs. It's safer because it won't delete anything.

[jcolls]

@jcolls yes, but this will remove all existing files on Your FTP, as I workaround I added --no-empty-dirs. It's safer because it won't delete anything.

Thanks. I thought --delete was to only remove files that did not exist, i.e if I delete a file then it will remove that file from FTP. But maybe this is achieved by deleting all and then uploading all.

I will change the ARGS to the one you have suggested for now. Cheers

[SamKirkland]

Sorry about this. ARGS is definitely supposed to be optional.
Should be fixed now!

--delete will remove files that exist on the server but don't exist on github.
Example: If I delete README.md and commit that change the file will still exist on the server but will not exist in source control.
If I use the --delete argument the README.md file will be removed from the server because it's no longer in source control.

[Misiu]

@SamKirkland I see that in recent PR You assign a default value to ARGS, but why do you use REMOTE_DIR instead of ARGS? https://github.com/SamKirkland/FTP-Deploy-Action/blob/master/entrypoint.sh#L11
Shouldn't it be WDEFAULT_ARGS=${ARGS:-""}? 🙂