Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLSecurity::SignedDocument.validate not recognizing X509Certificate text #25

Closed
danwoolley opened this issue Dec 8, 2011 · 4 comments

Comments

@danwoolley
Copy link
Contributor

I had this problem with two different providers. In def validate:

base64_cert = self.elements["//ds:X509Certificate"].text

returned an error because the ds:X509Certificate node was nil.

I changed it to

base64_cert = REXML::XPath.first(self, "//ds:X509Certificate", {"ds"=>DSIG}).text

and it was able to find the node and return the proper text.

@HHRy
Copy link

HHRy commented Dec 9, 2011

I've already got a pull request up that fixes this issue (had it with PingFederate) so +1 on getting this fixed. See ticket #23

@danwoolley
Copy link
Contributor Author

Ryan - I want to personally thank you for this project. SAML is very complex and I would hate to have to implement this stuff from scratch. It's much appreciated. Happy Holidays!

@HHRy
Copy link

HHRy commented Dec 9, 2011

Thanks for the thanks - but I've not had much to do with this project other than the one patch I've just submitted!

@stouset
Copy link
Contributor

stouset commented Nov 15, 2012

This appears to have been fixed in recent versions of ruby-saml.

@stouset stouset closed this as completed Nov 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants