Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release ruby-saml 4.8 gem with metadata.rb #27

Closed
toyokazu opened this issue Apr 13, 2012 · 5 comments
Closed

Please release ruby-saml 4.8 gem with metadata.rb #27

toyokazu opened this issue Apr 13, 2012 · 5 comments

Comments

@toyokazu
Copy link

Hi,

Thank you for your development of ruby-saml.
I am using your product in my code rack-saml and it is basically released through RubyGems.
Currently, I have an issue that I can not use Onelogin::Saml::Metadata in RubyGems version of ruby-saml 4.7.

toyokazu/rack-saml#2

If possible, could you release ruby-saml 4.8 with onelogin/saml/metadata.rb.

Best Regards

@jrozner
Copy link
Contributor

jrozner commented Apr 13, 2012

I've got a few changes in my local repo that I still need to clean up, test, and push. I'll try to get a new gem out tomorrow but if not should be able to before the end of the weekend

@toyokazu
Copy link
Author

Thank you for your quick reply.
I would like to wait the release :)

@jrozner
Copy link
Contributor

jrozner commented Apr 13, 2012

The changes have been pushed to github and a new gem has been released. I've done a lot of cleanup and attempted to fix some code that may have lead to potential problems. All test still pass and I haven't had any issues yet but please let me know if it breaks anything.

@jrozner jrozner closed this as completed Apr 13, 2012
@toyokazu
Copy link
Author

Thank you for your update!

When I load Onelogin::Saml::Metadata, I've got the following error

LoadError (cannot load such file -- onelogin/saml/validation_error):

I guess that it is caused by the require method in xml_security.rb.

% vi lib/xml_security.rb
require "onelogin/saml/validation_error"

It should be "onelogin/ruby-saml/validation_error", right?

@christianbpedersen
Copy link

You're absolutely right. I've fixed this. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants