Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with >11 floppies + Question #43

Closed
THLCX opened this issue Jan 6, 2019 · 2 comments
Closed

Problem with >11 floppies + Question #43

THLCX opened this issue Jan 6, 2019 · 2 comments

Comments

@THLCX
Copy link

THLCX commented Jan 6, 2019

Hello

There is a problem with the file FloppyDrives.cpp :
Only 11 floppies are supported, 16 are not because of implementation holes.

I fixed everything :
ThomasCyrix.com/files/FloppyDrives.cpp

Also, I can't find a way to simply select or unselected which channel will be active when playing the music.
It was a good feature in the 1st version of Moppy, is an update to add some easy and fast interface about this planned ?

Thanks for your work

@Sammy1Am
Copy link
Owner

Sammy1Am commented Jan 7, 2019

The current FloppyDrives.cpp is actually currently limited to 9 floppies because that's the maximum number supported by the Arduino Uno (I'm not sure what the ramifications of referencing pins beyond those defined for the Uno). If you'd like to submit your changes as a pull request that adds a distinct instrument for whatever board you have that supports additional drives, I'll consider pulling that in when I get a chance.

The quickest way to filter out a specific channel would be to change the first mapper to something like c!=3, which would essentially unselect channel 3. You can select which channels you do want using e.g. [1,3,5,7,9].includes(c) to select just odd channels.

The mapping boxes are admittedly a bit more complex than the UI that the original Moppy had, but they provide so much more flexibility that I think they're worth the trade off.

@Sammy1Am
Copy link
Owner

Closing due to lack of response, feel free to reopen if you've still got questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants