Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement line/word diff #39

Open
samoht opened this issue Apr 8, 2014 · 10 comments
Open

implement line/word diff #39

samoht opened this issue Apr 8, 2014 · 10 comments
Labels
area/core About Irmin-core type/feature Introduce a new feature

Comments

@samoht
Copy link
Member

samoht commented Apr 8, 2014

We don't currently merge two strings if both contents has been modified since the have branched from a common ancestor. To improve that, need to have a look at https://github.com/janestreet/patdiff but it seems to depend on https://github.com/janestreet/core_extended ... @diml any chance to have the patdiff library usable on mirage (ie. pure ocaml code) ?

@avsm
Copy link
Member

avsm commented Apr 8, 2014

Looks like https://github.com/janestreet/core_extended/blob/master/lib/patience_diff.ml is pretty standalone and doesn't really need the rest of Core_extended.

@ghost
Copy link

ghost commented Apr 9, 2014

Yeah I think we can pull this file out of core_extended without problem. I'll look into it.

@ghost
Copy link

ghost commented Apr 10, 2014

I haven't looked at the code in detail yet, but would patience_diff.ml be enough or are there things needed from patdiff/lib?

@samoht
Copy link
Member Author

samoht commented Apr 10, 2014

I think patience_diff.ml should be enough, though.

@samoht
Copy link
Member Author

samoht commented May 2, 2014

I've created https://github.com/samoht/ocaml-patience which depends only on core_kernel

@ghost
Copy link

ghost commented May 3, 2014

OK, actually we'll do this too for the next release.

@ghost
Copy link

ghost commented May 14, 2014

We created https://github.com/janestreet/patience_diff, shall it replace the patience package in opam?

@samoht
Copy link
Member Author

samoht commented May 14, 2014

Thanks! Yes, you can replace my temporary package, I'll update the Irminsule package.

@bmillwood
Copy link

patience_diff will be in opam as soon as ocaml/opam-repository#2062 goes through.

@samoht samoht modified the milestone: Next Jan 5, 2015
@samoht
Copy link
Member Author

samoht commented Feb 8, 2017

@samoht samoht removed this from the Next milestone Dec 8, 2020
@maiste maiste added area/core About Irmin-core type/feature Introduce a new feature and removed enhancement labels Jan 7, 2022
@maiste maiste added this to To sort in Irmin - Roadmap via automation Feb 4, 2022
@maiste maiste moved this from To sort to Unscheduled in Irmin - Roadmap Feb 4, 2022
@maiste maiste removed the unschedule label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core About Irmin-core type/feature Introduce a new feature
Projects
Irmin - Roadmap
Unscheduled
Development

No branches or pull requests

4 participants