New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement line/word diff #39
Comments
Looks like https://github.com/janestreet/core_extended/blob/master/lib/patience_diff.ml is pretty standalone and doesn't really need the rest of Core_extended. |
Yeah I think we can pull this file out of core_extended without problem. I'll look into it. |
I haven't looked at the code in detail yet, but would patience_diff.ml be enough or are there things needed from patdiff/lib? |
I think patience_diff.ml should be enough, though. |
I've created https://github.com/samoht/ocaml-patience which depends only on core_kernel |
OK, actually we'll do this too for the next release. |
We created https://github.com/janestreet/patience_diff, shall it replace the patience package in opam? |
Thanks! Yes, you can replace my temporary package, I'll update the Irminsule package. |
patience_diff will be in opam as soon as ocaml/opam-repository#2062 goes through. |
We don't currently merge two strings if both contents has been modified since the have branched from a common ancestor. To improve that, need to have a look at https://github.com/janestreet/patdiff but it seems to depend on https://github.com/janestreet/core_extended ... @diml any chance to have the patdiff library usable on mirage (ie. pure ocaml code) ?
The text was updated successfully, but these errors were encountered: