Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization on non final modifiable variable in SEService #41

Closed
GoogleCodeExporter opened this issue May 3, 2015 · 2 comments
Closed

Comments

@GoogleCodeExporter
Copy link

mReaders is defined as a non final private field in SEService.
The value is reset on each invocation of getReaders() (line #171)
However the code relies on mReaders for thread syncronization in shutdown code, 
while the variable can possible reset leading to a race.

In addition, onServiceDisconnected callback also syncronizes on mReaders. In 
case the user never called getReader mReaders will be equal to null leading to 
syncronization on null variable.

Original issue reported on code.google.com by kipo...@gmail.com on 6 Nov 2012 at 2:24

@GoogleCodeExporter
Copy link
Author

fixed in SCAPI-3.0.0

Original comment by Daniel.A...@gi-de.com on 15 Apr 2013 at 3:19

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

setting old issues from fixed to done

Original comment by Daniel.A...@gi-de.com on 5 Jul 2013 at 2:33

  • Changed state: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant