Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share button for plyr #1263

Closed
ahmadshc opened this issue Nov 18, 2018 · 4 comments
Closed

Share button for plyr #1263

ahmadshc opened this issue Nov 18, 2018 · 4 comments

Comments

@ahmadshc
Copy link

ahmadshc commented Nov 18, 2018

Hello
Can design and add social share button for your player?

The sharing button can have several different modes:

  1. share link (url) of page video in
  2. share link (url) of page video in, with picture of page and few description
  3. share embedable video code

Every one that you run is great
Thank you

@sampotts
Copy link
Owner

sampotts commented Nov 18, 2018 via email

@ahmadshc
Copy link
Author

I’m not sure this is something that is best built into the player. Another candidate for the ability to add custom buttons perhaps.

On 18 Nov 2018, at 8:29 pm, ahmadshc @.***> wrote: Hello Can design and add social share button for your player? The sharing button can have several different modes: share link (url) of page video in share link (url) of page video in, with picture of page and few description share embedable video code Whichever one you implement is great Thank you — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Thank you for reply.

@filips123
Copy link

This should be added as plugin (see #1242).

@sampotts
Copy link
Owner

sampotts commented Dec 8, 2018

I'd say there wouldn't be a requirement for this. The sharing should be done on the parent page rather than built into the player itself. Remember we want to keep the player as small as possible in terms of file size. Unfortunately we can't cater for everyone's requirements but only the masses.

The ability to add custom buttons (with a callback) is what's required for this.

@sampotts sampotts closed this as completed Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants