Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.supported is undefined when changing captions #2352

Closed
ThibaultNocchi opened this issue Oct 18, 2021 · 4 comments
Closed

this.supported is undefined when changing captions #2352

ThibaultNocchi opened this issue Oct 18, 2021 · 4 comments

Comments

@ThibaultNocchi
Copy link

Expected behaviour

There shouldn't be an error in the console when changing tracks

Actual behaviour

This console error is raised:

Uncaught TypeError: this.supported is undefined
    setup https://unpkg.com/plyr@3:1
    set currentTrack https://unpkg.com/plyr@3:1
    createMenuItem https://unpkg.com/plyr@3:1
    lt https://unpkg.com/plyr@3:1
    lt https://unpkg.com/plyr@3:1
    ge https://unpkg.com/plyr@3:1
    ge https://unpkg.com/plyr@3:1
    fe https://unpkg.com/plyr@3:1
    lt https://unpkg.com/plyr@3:1
    createMenuItem https://unpkg.com/plyr@3:1
    setCaptionsMenu https://unpkg.com/plyr@3:1
    update https://unpkg.com/plyr@3:1
    setTimeout handler*setup https://unpkg.com/plyr@3:1
    build https://unpkg.com/plyr@3:1
    wt https://unpkg.com/plyr@3:1
    <anonymous> https://cdpn.io/cp/internal/boomboom/pen.js?key=pen.js-ef204373-eaa0-7eac-0ca1-d47f23a19710:3
plyr@3:1:36562

Steps to reproduce

Environment

  • Browser: FF 93.0 and Chromium 94.0.4606.81
  • Operating System: Linux

Console errors (if any)

Given above

Link to where the bug is happening

The basic demo displays it

Thanks in advance, have a nice day!

@tractorcow
Copy link

I encountered this issue on 3.6.12, and attempted a slight downgrade. 3.6.8 did not have this issue, if that helps narrow down the search range.

@tractorcow
Copy link

tractorcow commented Apr 1, 2022

Perhaps it could be related to #2261

Maybe this will resolve.

captions.setup.call(this);

This was referenced Apr 1, 2022
@tractorcow
Copy link

Fixed with #2399

@sampotts
Copy link
Owner

sampotts commented Apr 18, 2022

Thanks for the teamwork in fixing this. The fix is released in v3.7.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants