Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple videos loading SVG's multiple times #259

Closed
thiagupct opened this issue Jun 2, 2016 · 4 comments
Closed

Multiple videos loading SVG's multiple times #259

thiagupct opened this issue Jun 2, 2016 · 4 comments

Comments

@thiagupct
Copy link

If 10 videos were loaded in a single page and plyr was initiated using plyr.setup() 10 times svg was loaded. Can't we limit the same to a single request as a single file is enough to serve the controls for 10 videos.

@sampotts
Copy link
Owner

sampotts commented Jun 2, 2016

Cheers for this. Just pushed an updated version. Could you give it a try? 👍

@cywtf
Copy link

cywtf commented Aug 10, 2016

This is issue is still persistent.
I made a new test: 4 videos loaded in a single page, plyr initiated using plyr.setup() and 4 times the svg was loaded. Please see: https://s.codepen.io/rootion/debug/rLoLOa

@sampotts
Copy link
Owner

Sorry - I've been working on a refactor of multiple issues and this is included. Hoping to get a fix for this out in the next few days.

@sampotts sampotts reopened this Aug 10, 2016
@sampotts
Copy link
Owner

sampotts commented Aug 21, 2016

This should be fixed in v2.0.0 - could you give it a go? Bear in mind there were also several breaking changes so check the changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants