Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand public configuration and allow for API keys #11

Closed
danpastori opened this issue Oct 1, 2018 · 1 comment · Fixed by #16
Closed

Expand public configuration and allow for API keys #11

danpastori opened this issue Oct 1, 2018 · 1 comment · Fixed by #16

Comments

@danpastori
Copy link
Contributor

Problem

As we integrate more social networks, such as subscribe on Youtube, we might need
to account for public facing API keys or username data.

Rationale

As we expand more buttons, and use Shr for more features, just allowing the user
to pass in the proper API keys/username data will be extremely helpful.

Solution

I'll expand the config to allow for more buttons to be added by handling API keys,
user names, or other config options.

Pros of Solution:

  • Shr will allow for more buttons to be added.

Cons of Solution:

  • Shr will handle more featurs, but is this something you want?

If you'd like to move forward, let me know and I'll submit a PR!

@sampotts
Copy link
Owner

sampotts commented Oct 2, 2018

Makes total sense to do this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants