Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local storage test is flawed. #2

Closed
danfoley opened this issue Sep 29, 2017 · 2 comments
Closed

Local storage test is flawed. #2

danfoley opened this issue Sep 29, 2017 · 2 comments

Comments

@danfoley
Copy link
Contributor

danfoley commented Sep 29, 2017

this block of code here should be removed from the local storage test:

if ('localStorage' in window && window.localStorage !== null) {
        return false;
}

that is going to return false if something else already is using local storage, even thought it still is available for use. Remove that block and all will be fine.

@danfoley
Copy link
Contributor Author

@sampotts
Copy link
Owner

sampotts commented Oct 2, 2017

Merged your PR, cheers 👍

@sampotts sampotts closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants