Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毟 React Select Input - v2.0.0 #2

Open
samrith-s opened this issue Aug 21, 2018 · 0 comments
Open

馃毟 React Select Input - v2.0.0 #2

samrith-s opened this issue Aug 21, 2018 · 0 comments

Comments

@samrith-s
Copy link
Owner

The release of v1.0.0 of this package has been very delayed, apologies for that.

Considering the package is still being used by some people and is getting regular downloads, getting a head-start on the second version is only necessary.

Why?

The second version will be a complete rewrite of the package. In the current version, the package was written very casually. Simple stuff like PropTypes were ignored in order to get the package out as quick as possible.

Version 2 aims to rectify these discrepancies, and make the component compatible with future versions of React.

What's in the new version?

There will be some breaking changes in terms of methods and properties both. Right now, the entire functionality is written in one file. The focus on maintainability and scalability, coupled with better documentation and warnings in dev mode.

  • onKeyUp and onKeyDown methods will be deprecated in favour of onKeyPress
  • Custom rendering for options
  • openUp improvements
  • disableEnter to be removed
  • inputProps to add props directly to the input tag
  • Native support for debouncing/throttling
  • Asynchronous options support

Additionally

In v1.0.1, ESLint, Prettier and lint rules were added. v2.0.0 plans to build the entire code-base on it, something which should have been done from the start.

There will be tests written using Enzyme, and proper coverage provided.

The docs are also going to be written from scratch. That being said, the entire code will be documented, to enable contributors to easily understand the code. A lot more usage and code examples will be created.

@samrith-s samrith-s self-assigned this Aug 21, 2018
@samrith-s samrith-s changed the title 馃毟React Select Input - v2.0.0 馃毟 React Select Input - v2.0.0 Aug 21, 2018
@samrith-s samrith-s pinned this issue Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant