New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: web accessible scripts #31
feat: web accessible scripts #31
Conversation
Closes #30 |
Thanks for the PR! Could you add some tests for these changes? Should be very similar to |
Added some tests following the pattern for resources. |
ping @samrum ? |
Ah, I see a missing dev dependency, but on my local machine I'm getting the same test failures about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things, the test failures related to html are because of the unfiltered web accessible resource input pushes
Also, your tests need to be added to |
@samrum Thank you for the guidance, it was a huge help! I believe that should take care of it. |
@samrum I see the merge is blocked since those commits aren't signed, how do you suggest we proceed? Do you want me to open a new PR with a squashed and signed commit? |
5ebde56
to
534e61a
Compare
@samrum okay, I've retroactively signed all commits. I think it's ready to merge :) |
Adds ability to transpile scripts that user includes as web accessible resources. For instance, if a content script needs to inject an inpage script into the webpage at runtime, the user can simply include the path to the inpage script as a
web_accessible_resource
and the plugin will take care of the rest.This PR also adds a new plugin option
webAccessibleScripts
that simply mirrors the inputs tocreateFilter
, allowing user to control which files will match as scripts: