Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify MV3-in-Firefox support in README #61

Closed
Vinnl opened this issue Nov 3, 2022 · 3 comments · Fixed by #63
Closed

Clarify MV3-in-Firefox support in README #61

Vinnl opened this issue Nov 3, 2022 · 3 comments · Fixed by #63
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@Vinnl
Copy link

Vinnl commented Nov 3, 2022

It wasn't entirely clear to me from the README whether MV3 in Firefox is supported. Trying it out it seems like no? Since the serve:firefox script did not pass --firefox-preview mv3 to web-ext, the manifest.ts lists a service_worker (not yet supported by Firefox), and even after fixing those two issues, I get "Error: Extension is invalid".

To set expectations, it would be nice if the README had an indication of the current status of support for MV3 in Firefox :)
@samrum
Copy link
Owner

samrum commented Nov 3, 2022

Good point! Firefox didn’t have any manifest V3 support at the time, but I do understand they have some experimental support now.
I haven’t looked into it much, but can definitely note that it’s not usable in the developer preview at the moment and see what’s required for it to work.

@samrum samrum added the documentation Improvements or additions to documentation label Nov 3, 2022
@samrum samrum mentioned this issue Nov 17, 2022
Merged
@samrum samrum added the enhancement New feature or request label Nov 17, 2022
@samrum
Copy link
Owner

samrum commented Nov 22, 2022

Added a "Firefox Experimental Manifest V3" example to the readme that explains how to configure the plugin to work with it. Requires v2.2.0 of the plugin.

@Vinnl
Copy link
Author

Vinnl commented Nov 22, 2022

Oh wow, experimental support is even better, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: firefox experimental manifest V3 support samrum/vite-plugin-web-extension
2 participants
@Vinnl @samrum