Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-loader is both a devDependency and peerDependency at incompatible version ranges #19

Open
ThisIsMissEm opened this issue Oct 24, 2018 · 4 comments

Comments

@ThisIsMissEm
Copy link

In devDependencies, there is "ts-loader": "3.x", but in peerDependencies there's "ts-loader": "^4.4.1"

I'm not sure why ts-loader is a peer dependency; seems like it should only be a development dependency?

@stephen
Copy link
Contributor

stephen commented Oct 24, 2018

We added the peer dep for use with typescript code generation. Thinking about it more, that should maybe be an optionalDependency instead? see #16)

I think but haven't verified that we don't care too much about which version to target, so we could change both to 3.x || 4.x. wdyt?

@ThisIsMissEm
Copy link
Author

@stephen ah, yes, then I'd say optionalDependency — was confusing to see it come up when installing; I've also noticed this module isn't yet updated to webpack 4, which is likely a fair amount of work (I'm currently just using this module due to a bug in https://github.com/prisma/graphql-import-loader)

@stephen
Copy link
Contributor

stephen commented Oct 24, 2018

we use it internally with webpack 4 today - likely we need to bump the dep version range there to 3.x || 4.x as well.

@ThisIsMissEm
Copy link
Author

@stephen on webpack, there's probably a more extensive upgrade needed, but that'd be to switch to the new loader APIs, for now we're supporting webpack 3, but should probably drop support for 3 in favour of webpack 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants