2 tests fail if /usr/local/share does not exist

[ceamac]

Describe the bug

There are tests that use /usr/local/share as a path that exists on all Unix systems. Gentoo does not have that path created by default. This causes the tests to fail.

To Reproduce

Remove (or rename) /usr/local/share and run the tests.

    def test_path_exists_case_insensitive():
    
        # choose a path which exists on all Unix systems
        path = "/usr/local/share"
    
        assert denormalize_path(path) == path
>       assert denormalize_path(path.title()) == path
E       AssertionError: assert '/usr/local/Share' == '/usr/local/share'
E         - /usr/local/share
E         ?            ^
E         + /usr/local/Share
E         ?            ^

path       = '/usr/local/share'

tests/offline/utils/test_path.py:23: AssertionError
___________________________________________________________________________________________ test_cased_path_candidates ____________________________________________________________________________________________

    def test_cased_path_candidates():
    
        # test that we can find a unique correctly cased path
        # starting from a candidate with scrambled casing
    
        path = "/usr/local/share".upper()
        candidates = equivalent_path_candidates(path)
    
        assert len(candidates) == 1
>       assert "/usr/local/share" in candidates
E       AssertionError: assert '/usr/local/share' in ['/usr/local/SHARE']

candidates = ['/usr/local/SHARE']
path       = '/USR/LOCAL/SHARE'

tests/offline/utils/test_path.py:47: AssertionError

Expected behaviour

Tests should pass.

System:

• Maestral version: 1.5.2
• Python version: 3.9.9
• OS: [e.g. Ubuntu] Gentoo
• Desktop environment: [e.g. Gnome 3.32] Gnome 40.0
• PyQt version (for Linux GUI): 5.15.4

Additional context

I suggest using /usr/bin or /usr/share instead.

[samschott]

Oh, good catch! You live and learn :)