Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jobs that unexpectedly raise/exit are never retried #95

Open
jonnystoten opened this issue Mar 9, 2020 · 1 comment · May be fixed by #96
Open

Jobs that unexpectedly raise/exit are never retried #95

jonnystoten opened this issue Mar 9, 2020 · 1 comment · May be fixed by #96

Comments

@jonnystoten
Copy link

jonnystoten commented Mar 9, 2020 •
edited
Loading

If a module-based job returns :error or {:error, reason}, retry_at is called on the module to determine whether to retry. However, if the job raises or exits because of an error, retry_at is not called on the module so the job is never retried.

I'm happy to take a look at a PR for this!
@jonnystoten jonnystoten changed the title Jobs that unexpectedly exit are never retried Jobs that unexpectedly raise/exit are never retried Mar 10, 2020
@jonnystoten jonnystoten linked a pull request Mar 10, 2020 that will close this issue
Open
@samsondav
Copy link
Owner

@jonnystoten Hi and thanks for the PR!

I've left a comment there. Let's move discussion onto the code 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retry jobs even when they raise/exit jonnystoten/rihanna
2 participants
@jonnystoten @samsondav