Skip to content
This repository has been archived by the owner on Apr 27, 2020. It is now read-only.

Proxy /flow/{name}/configs #41

Closed
wrathagom opened this issue Jul 26, 2017 · 5 comments
Closed

Proxy /flow/{name}/configs #41

wrathagom opened this issue Jul 26, 2017 · 5 comments

Comments

@wrathagom
Copy link
Contributor

wrathagom commented Jul 26, 2017

Just like we proxy /data, I want to proxy /configs, which will be used to manage flow configurations. Some flows will have a lot of these, some probably will have none. But I want the existence of this flow configuration to exist on all flows.

2017-07-25_20-44-56 1

Just feel like it's worth saying so that no one mis-reads the :name in the above image is the name of the configuration parameter not of the flow. the name of the flow would replace TEST_URL

@wrathagom wrathagom changed the title Proxy /flow/:name/configs Proxy /flow/{name}/configs Jul 26, 2017
@milutz
Copy link
Contributor

milutz commented Aug 1, 2017

@malave Is this still open? (if done, please close (or at least add a comment that its done))

@wrathagom
Copy link
Contributor Author

he's been working on the plugin since I created this, to my knowledge it isn't done.

@malave
Copy link
Collaborator

malave commented Aug 2, 2017

@milutz what @wrathagom said.

@malave
Copy link
Collaborator

malave commented Aug 8, 2017

@wrathagom so the config part is clear, but I have a question about /data that I see in that diagram. RIght now we have this path proxied from the API to node-red:

/flow/{name}/data -> /TEST_URL

so we are using the root path in node-red but you diagram shows that you are using

/TEST_URL/data

Do you want me to change the data path and have this 2 urls proxied:

/flow/{name}/data -> /TEST_URL/data
/flow/{name}/configs -> /TEST_URL/configs

@wrathagom
Copy link
Contributor Author

Yep, I think it makes things clearer rather than having one at the root and one not.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants