Skip to content
This repository has been archived by the owner on Apr 27, 2020. It is now read-only.

Better error messages and handling during channel creation #48

Closed
wrathagom opened this issue Aug 28, 2017 · 2 comments
Closed

Better error messages and handling during channel creation #48

wrathagom opened this issue Aug 28, 2017 · 2 comments

Comments

@wrathagom
Copy link
Contributor

wrathagom commented Aug 28, 2017

User Stories

  • As a channel creator I want to know why my flow failed to be created so that I can correct any mistakes I may have made.
  • As a channel creator I want flows that fail to be created in ES and Node-RED to be rolled back so that I am not left with dangling channels.

Right now there is a missing parameter I can see that in the console output, but the returned error just states Invalid Flow Template Id or Parameter array supplied. If we know that a parameter is missing we should return that to the user.

@wrathagom wrathagom changed the title Improve Error Messages when creating instances of flows Better Error Messages and Handling During Channel Creation Sep 28, 2017
@wrathagom wrathagom changed the title Better Error Messages and Handling During Channel Creation Better error messages and handling during channel creation Sep 28, 2017
@malave
Copy link
Collaborator

malave commented Apr 10, 2018

@wrathagom, @ewoo: We should revisit this issue during the EUI update or shorty after. Most errors returned by the API are not shown or are not handled correctly in the UI. For example when there is an error on flow creation it just send you to the list page afterwards.

@wrathagom wrathagom added this to the v2.0 Release milestone Apr 10, 2018
@wrathagom
Copy link
Contributor Author

I'm fine with rolling it into the EUI changes. Given that you'll likely use something like the EUI toast to display the: https://elastic.github.io/eui/#/guidelines/toasts

@malave malave closed this as completed Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants