Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tables to follow the data-tables guidelines #2

Closed
6 of 7 tasks
samtimalsina opened this issue Jun 18, 2017 · 0 comments
Closed
6 of 7 tasks

Update tables to follow the data-tables guidelines #2

samtimalsina opened this issue Jun 18, 2017 · 0 comments

Comments

@samtimalsina
Copy link
Owner

samtimalsina commented Jun 18, 2017

Spec reference: https://www.google.com/design/spec/components/data-tables.html
MDC Blocker: material-components/material-components-web#57

MDC is missing the Data Table component. This is sad because Drupal uses tables extensively. The blocker is not going away for a few months. For the time-being, I have a custom css+js solution in place. This does not conform to MDC component design (which is out of the scope for this project anyways.)

In any case, the data-table look pretty much like the guidelines except for a few issues:

Cosmetic Issues:

  • Table content should be 13sp Roboto Regular.
  • The ripple on Filter button should be smaller and above the other content.
    image
  • Column name hover (Desktop) has not been implemented.
    image
    image
  • The footer control sets (pagination), differs from the the guidelines in certain ways. For example, in Drupal tables, you don't the ability to choose rows per page. Also, the guideline doesn't have page numbers. This should probably be a separate issue and communicate with the MDC team for guidance.
  • Css issue in the footer control sets.
    image
  • The action menu looks out of place because of the font-size, but need to confirm with the MDC team to make sure changing the font size here is ok. This has implications on smaller devices.
    image

Behavior

  • Action buttons (the node bulk form) can go to the alternate header.
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant