Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offer figure_plot = TRUE for FeaturePlot_scCustom #127

Closed
wwzhang opened this issue Sep 19, 2023 · 6 comments
Closed

offer figure_plot = TRUE for FeaturePlot_scCustom #127

wwzhang opened this issue Sep 19, 2023 · 6 comments
Assignees
Labels
enhancement Enhance existing function/feature

Comments

@wwzhang
Copy link

wwzhang commented Sep 19, 2023

Could it possible to add an option to remove axes similar to figure_plot = TRUE of DimPlot_scCustom? figure_plot = TRUE is a quite a handy feature for 2d plots but sadly it is not available for FeaturePlot

@samuel-marsh
Copy link
Owner

Hi,

Thanks for submitting this issue! This had been in my to do list for while but appears to have been lost along the way. I have just added it to my V5 compatibility ToDo list. I’ll update here when it’s implemented in develop branch.

Thanks,
Sam

@samuel-marsh samuel-marsh self-assigned this Sep 22, 2023
@samuel-marsh samuel-marsh added the enhancement Enhance existing function/feature label Sep 22, 2023
@samuel-marsh
Copy link
Owner

Hi,

Just wanted to give you an update. This is still on to do list but unfortunately is likely going to be bumped until after the v2.0.0 release coming up to match up with full Seurat 5 release. Unfortunately, as one person team just not enough bandwidth to execute before Seurat5 release. I'm actually going to work on making Figure_Plot its own function that can be supplied following plots like ggplot theming so that it can easily be called for any DimPlot based plot. I'll update in next few weeks when I have it working in dev branch.

Best,
Sam

@wwzhang
Copy link
Author

wwzhang commented Oct 27, 2023

Thank you.

On a side note, will seuratv5 change a lot functions of sccustomize?

@samuel-marsh
Copy link
Owner

I’ve been working to ensure functions aren’t impacted but inevitably probably will be couple bugs in first release (there always are). But as of right now with my testing all functions are working as expected (most of that credit though goes to Seurat devs for ensuring backwards compatibility of Seurat 5 with existing workflows). Number of new functions and added capabilities/parameters also coming in v2.0.0 release.

Changes/Updates thus far can be found here;
https://github.com/samuel-marsh/scCustomize/blob/develop_V5/NEWS.md

Best,
Sam

@wwzhang
Copy link
Author

wwzhang commented Oct 28, 2023

thanks

@samuel-marsh
Copy link
Owner

Hi @wwzhang,

This enhancement has been implemented now in "develop_V5" branch v1.9.9.9040 in all 2D DR plots. If you run into any issues with the figure_plot parameter after this update please let me know and I can reopen issue.

Best,
Sam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing function/feature
Projects
None yet
Development

No branches or pull requests

2 participants