Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust size x-axis labels (col_label_size) #96

Closed
massonix opened this issue Mar 21, 2023 · 6 comments
Closed

Adjust size x-axis labels (col_label_size) #96

massonix opened this issue Mar 21, 2023 · 6 comments
Assignees
Labels
enhancement Enhance existing function/feature

Comments

@massonix
Copy link

Hey Sam,

Thanks once more for developing this very useful package! Here's a plot I generated with the following code:

Clustered_DotPlot(
  seurat,
  features = pos_genes,
  colors_use_exp = viridis::inferno(20),
  colors_use_idents = cols_annotation,
  row_label_size = 6,
  plot_km_elbow = FALSE,flip = TRUE
)

image

As you can see, I could adjust the size of the cluster labels (rows), but I would also like to adjust the size of the column labels (features), as well as the size of the legend text. Would it be possible to add two additional parameters to do so?

Thanks!

Ramon

@samuel-marsh
Copy link
Owner

Hey Ramon,

Thanks so much (and congrats on your Ph.D. defense!). Yes I agree I think those parameters should be added. The column labels are easy and the legend font size should totally be possible but will have to do little extra testing there to make sure that all of the legend components get modified correctly. I'll update here when it's ready.

Best,
Sam

@samuel-marsh samuel-marsh self-assigned this Mar 22, 2023
@samuel-marsh samuel-marsh added the enhancement Enhance existing function/feature label Mar 22, 2023
@massonix
Copy link
Author

Thanks Sam, I truly appreciate this!

Ramon

@samuel-marsh
Copy link
Owner

samuel-marsh commented Mar 23, 2023

No problem! Just update will probably be next week. I have the column labels and 2 of 3 legend components and their titles working. Just gotta get third to follow suit. At conference rest of week but will get it pushed next week.

Best,
Sam

@samuel-marsh
Copy link
Owner

Ok actually easy fix so we are up and running on the develop branch (v1.1.1.9007). There are 3 new parameters:

  • column_label_size to change the column labels
  • legend_label_size to change the labels of the legend guides
  • legend_title_size to change size to guide titles.

If any of these doesn't work for you or if there are other changes you think would be helpful just let me know! I'll close issue for now but will reopen if there are any continued bugs once you test it out.

Best,
Sam

@massonix
Copy link
Author

thanks so much! I will try it out soon

@massonix
Copy link
Author

It's much cleaner now!

Clustered_DotPlot(
  seurat,
  features = pos_genes,
  colors_use_exp = viridis::inferno(20),
  colors_use_idents = cols_annotation,
  row_label_size = 6,
  column_label_size = 6,
  legend_label_size = 6,
  legend_title_size = 6,
  plot_km_elbow = FALSE,
  flip = TRUE
)

image

The "Identity" title is mildly annoying but I can take it out with Inkscape for now.

Thanks so much for your efforts in this beautiful package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing function/feature
Projects
None yet
Development

No branches or pull requests

2 participants